New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: Pressing Down in Tab moves focus to Panel #4134

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
3 participants
@mcsf
Contributor

mcsf commented Dec 22, 2017

Description

Fixes #3849. Per #3849 (comment), the remaining task was to allow pressing the arrow down key () when focusing an inserter tab (Recent, Blocks, &c.) to move focus to the selected panel.

How Has This Been Tested?

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
@afercia

@mcsf thanks! Functionally looks good to me! Will leave to others code-wise considerations.

// moves focus to the selected panel below.
if (
event.keyCode === keycodes.DOWN &&
document.activeElement.getAttribute( 'role' ) === 'tab'

This comment has been minimized.

@iseulde

iseulde Dec 26, 2017

Member

Was confused for a second... Tabbable tabs 🤯

@iseulde

iseulde Dec 26, 2017

Member

Was confused for a second... Tabbable tabs 🤯

@mcsf

This comment has been minimized.

Show comment
Hide comment
@mcsf

mcsf Jan 3, 2018

Contributor

Rebased against latest master, will merge soon.

Contributor

mcsf commented Jan 3, 2018

Rebased against latest master, will merge soon.

@mcsf mcsf closed this Jan 3, 2018

@mcsf mcsf reopened this Jan 3, 2018

@mcsf

This comment has been minimized.

Show comment
Hide comment
@mcsf

mcsf Jan 3, 2018

Contributor

Closing-then-reopening was an attempt to retrigger CI tests. ¯\_(ツ)_/¯

Contributor

mcsf commented Jan 3, 2018

Closing-then-reopening was an attempt to retrigger CI tests. ¯\_(ツ)_/¯

@mcsf mcsf merged commit 3784c32 into master Jan 3, 2018

1 of 3 checks passed

codecov/project CI failed.
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mcsf mcsf deleted the update/inserter-down-key-into-panel branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment