New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery Block: Drag and drop multiple images create a gallery block #4148

Merged
merged 2 commits into from Dec 22, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Dec 22, 2017

closes #3364

This PR adds a "transformation" to allow drag and dropping multiple images to the editor canvas in order to create a gallery block.

This doesn't solve the lack of feedback while the upload is in progress, this issue is not specific to the gallery block and I believe is tracked in a separate issue.

Testing instructions

  • Drag multiple images to the editor canvas
  • After the images upload, A gallery block should appear.

@youknowriad youknowriad self-assigned this Dec 22, 2017

@youknowriad youknowriad requested a review from jasmussen Dec 22, 2017

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Dec 22, 2017

Contributor

This works great! Really really killer feature, this. Nice work.

The missing upload feedback would be nice to address for both images and galleries, but as you say, doesn't have to be this PR.

Can we tweak the "drop files to upload" stuff a little bit? The icon isn't critically necessary, and a 13px default font would be nice. And if you can use $medium-blue-500 for the bg color, that would be stellar:

dragondrop

Contributor

jasmussen commented Dec 22, 2017

This works great! Really really killer feature, this. Nice work.

The missing upload feedback would be nice to address for both images and galleries, but as you say, doesn't have to be this PR.

Can we tweak the "drop files to upload" stuff a little bit? The icon isn't critically necessary, and a 13px default font would be nice. And if you can use $medium-blue-500 for the bg color, that would be stellar:

dragondrop

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Dec 22, 2017

Contributor

Can we tweak the "drop files to upload" stuff a little bit? The icon isn't critically necessary, and a 13px default font would be nice. And if you can use $medium-blue-500 for the bg color, that would be stellar

This placeholder is the same used elsewhere images, galleries etc... Are you suggesting we tweak it only for the empty post use-case? (your screenshot)

Also, I think the background color has been changed at some point to match the Accessibility guidelines.

Contributor

youknowriad commented Dec 22, 2017

Can we tweak the "drop files to upload" stuff a little bit? The icon isn't critically necessary, and a 13px default font would be nice. And if you can use $medium-blue-500 for the bg color, that would be stellar

This placeholder is the same used elsewhere images, galleries etc... Are you suggesting we tweak it only for the empty post use-case? (your screenshot)

Also, I think the background color has been changed at some point to match the Accessibility guidelines.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Dec 22, 2017

Contributor

If there's a solid reason why the upload message looks like that, it's okay for us to keep it unchanged. But it seems like it's at least inheriting the body font, so it might be the case that it should be using a different font at least.

CC: @afercia can you recall details around this?

Contributor

jasmussen commented Dec 22, 2017

If there's a solid reason why the upload message looks like that, it's okay for us to keep it unchanged. But it seems like it's at least inheriting the body font, so it might be the case that it should be using a different font at least.

CC: @afercia can you recall details around this?

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Dec 22, 2017

Contributor

I've forced the default font for the dropzone and removed the icon but only for the empty post placeholder's dropzone. I think it's better now.

Contributor

youknowriad commented Dec 22, 2017

I've forced the default font for the dropzone and removed the icon but only for the empty post placeholder's dropzone. I think it's better now.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Dec 22, 2017

Contributor

🎉

Looks good, design wise.

Contributor

jasmussen commented Dec 22, 2017

🎉

Looks good, design wise.

@youknowriad youknowriad merged commit e109ff7 into master Dec 22, 2017

3 checks passed

codecov/project 39.02% (-0.03%) compared to f023754
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the add/drag-drop-multiple-images-2-gallery branch Dec 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment