New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: Show the insertion point when the inserter is opened #4160

Merged
merged 1 commit into from Dec 27, 2017

Conversation

Projects
None yet
4 participants
@youknowriad
Contributor

youknowriad commented Dec 25, 2017

closes #4102

This PR updates the inserter to show the insertion point whenever the block inspector is opened, not waiting for the user to hover a block before doing so.

Testing instructions

  • Open any inserter
  • The insertion point should be visible
  • Close the inserter or insert a block
  • The insertion point should disappear.

@youknowriad youknowriad self-assigned this Dec 25, 2017

@youknowriad youknowriad requested a review from jasmussen Dec 25, 2017

*
* @return {Object} Action object
* @return {Object} Action object

This comment has been minimized.

@iseulde

iseulde Dec 25, 2017

Member

Spacing issue?

@iseulde

iseulde Dec 25, 2017

Member

Spacing issue?

@iseulde

This comment has been minimized.

Show comment
Hide comment
@iseulde

iseulde Dec 25, 2017

Member

Works great here. I'm just noticing a slight delay for the plus icon to pop up after the blue line shows, also when it hides. Is it supposed to work like that?

Member

iseulde commented Dec 25, 2017

Works great here. I'm just noticing a slight delay for the plus icon to pop up after the blue line shows, also when it hides. Is it supposed to work like that?

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Dec 26, 2017

Contributor

@iseulde Oh I see, I believe this is due to the CSS animation of the sibling inserter. We can probably make it quicker if needed.

Contributor

youknowriad commented Dec 26, 2017

@iseulde Oh I see, I believe this is due to the CSS animation of the sibling inserter. We can probably make it quicker if needed.

@iseulde

This comment has been minimized.

Show comment
Hide comment
@iseulde

iseulde Dec 26, 2017

Member

I guess it makes sense for hover, but maybe not so much with the inserter? Anyway, it's the same as before, can be adjusted later.

Member

iseulde commented Dec 26, 2017

I guess it makes sense for hover, but maybe not so much with the inserter? Anyway, it's the same as before, can be adjusted later.

@youknowriad youknowriad merged commit 45e9094 into master Dec 27, 2017

3 checks passed

codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +0.72% compared to 79a74be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/insertion-point branch Dec 27, 2017

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Jan 3, 2018

Member

A nice simplification 👍

Member

aduth commented Jan 3, 2018

A nice simplification 👍

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Jan 3, 2018

Contributor

❤️

Contributor

jasmussen commented Jan 3, 2018

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment