New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Boxes: When the metaboxes are saving ensure the overlay covers t… #4170

Merged
merged 1 commit into from Dec 26, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Dec 26, 2017

closes #3771

When meta boxes are saving an invisible overlay is added to avoid editing their content while saving is in progress. Some meta boxes can use "float" alignments (ACF) which caused the overlay to not cover the whole area.

Testing instructions

  • Add an ACF field
  • Create, edit and save the post
  • While the meta box is being saved, ensure that you can't focus and type in the field.

@youknowriad youknowriad self-assigned this Dec 26, 2017

@youknowriad youknowriad requested a review from BE-Webdesign Dec 26, 2017

@BE-Webdesign

🚢

@youknowriad youknowriad merged commit c3be1b6 into master Dec 26, 2017

3 checks passed

codecov/project 39.08% remains the same compared to ecee09e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/metabox-overlay branch Dec 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment