New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if mac when displaying editor mode toggle shortcut #4194

Merged
merged 2 commits into from Dec 28, 2017

Conversation

Projects
None yet
3 participants
@vladanost
Contributor

vladanost commented Dec 28, 2017

Description

Related to #3755
Detecting Mac when displaying editor mode toggle shortcut.

How Has This Been Tested?

Tested on Mac and Linux.

Types of changes

New feature (non-breaking change which adds functionality)

@youknowriad

Thanks 👍

@youknowriad youknowriad merged commit b407ccc into WordPress:master Dec 28, 2017

2 checks passed

codecov/project 39.14% (-0.01%) compared to 003d533
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vladanost vladanost deleted the vladanost:try/detect-platform-for-editor-mode-toggle-shortcut-display branch Dec 28, 2017

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Jan 3, 2018

Member

If this file is consumed by the KeyboardShortcuts (or Mousetrap generally) we can use the mod keyword to automatically toggle Command / Ctrl.

https://craig.is/killing/mice

Member

aduth commented Jan 3, 2018

If this file is consumed by the KeyboardShortcuts (or Mousetrap generally) we can use the mod keyword to automatically toggle Command / Ctrl.

https://craig.is/killing/mice

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Jan 3, 2018

Contributor

@aduth This is for "display" purpose. To show the actual shortcut in the ellipsis menu.

Contributor

youknowriad commented Jan 3, 2018

@aduth This is for "display" purpose. To show the actual shortcut in the ellipsis menu.

getsource added a commit to getsource/gutenberg that referenced this pull request Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment