New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured image: remove unused fields from media modal #4197

Merged
merged 2 commits into from Jan 2, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Dec 28, 2017

Description

This PR aims to fix #2330 it removes the option to change the caption and description when setting the featured image.

How Has This Been Tested?

Set a featured image and verify fields caption and description do not appear on media modal.

Screenshots (jpeg or gifs if applicable):

image

Types of changes

Added the ability to set an additional class to media modal in MediaUploadButton component.
Added CSS to hide caption and description on featured image modal.

@youknowriad

This works, but it's probably better fixed in the media modal with a config or something.

Maybe a comment somewhere to clarify this?

@jorgefilipecosta jorgefilipecosta merged commit d931e5f into master Jan 2, 2018

3 checks passed

codecov/project 40.8% (+1.63%) compared to 617edcb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the update/featured-image-remove-unused-fields branch Jan 2, 2018

@jorgefilipecosta

This comment has been minimized.

Show comment
Hide comment
@jorgefilipecosta

jorgefilipecosta Jan 2, 2018

Member

Thank you for the review @youknowriad, a comment was added 👍

Member

jorgefilipecosta commented Jan 2, 2018

Thank you for the review @youknowriad, a comment was added 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment