Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add an example for the e2e tests snapshot update #41999

Merged
merged 2 commits into from Jun 28, 2022

Conversation

Mamaduka
Copy link
Member

What?

PR documents method for updates e2e test snapshots.

Testing Instructions

None

@Mamaduka Mamaduka self-assigned this Jun 28, 2022
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Jun 28, 2022
@Mamaduka Mamaduka requested a review from talldan June 28, 2022 08:43
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I guess it may be worth adding instructions for Playwright as well, but I don't know what they are 🤔

@Mamaduka
Copy link
Member Author

Mamaduka commented Jun 28, 2022

I guess it may be worth adding instructions for Playwright as well, but I don't know what they are 🤔

I've not used Playwright's command so far. Maybe it should be a part of the migration guide for now. @kevin940726, what do you think?

@kevin940726
Copy link
Member

Good idea! It's pretty similar in Playwright, just append -u to the CLI. Official doc here.

@Mamaduka
Copy link
Member Author

Thanks, @kevin940726. Added Playwright instrcution as well.

@Mamaduka Mamaduka merged commit c386db3 into trunk Jun 28, 2022
@Mamaduka Mamaduka deleted the docs/e2e-tests-snapshot-update-example branch June 28, 2022 11:23
@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants