New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Markdown and HTML without requiring a double line break #4232

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
3 participants
@iseulde
Member

iseulde commented Jan 2, 2018

Description

See #3949 (comment). The removes the double line check for plain text Markdown/HTML parsing. Instead, we'll force inline pasting if the plain text did not contain a lie break and the result is a paragraph.

How Has This Been Tested?

Pasting the following should create a list.

* one
* two
* three

A piece of Markdown without a line break should be pasted inline:

some **bold** text

A piece of plain text HTML should not be pasted inline, it should create a new paragraph block.

<p>This is <strong>bold</strong>.</p>

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@iseulde iseulde requested a review from mcsf Jan 2, 2018

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Jan 3, 2018

Contributor

Thanks for adding tests for these.

Contributor

mtias commented Jan 3, 2018

Thanks for adding tests for these.

@mcsf

mcsf approved these changes Jan 3, 2018

Thanks for fixing this. :)

@iseulde iseulde merged commit 7557026 into master Jan 3, 2018

3 checks passed

codecov/project 39.78% (+0.62%) compared to eb7b0b7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the fix/plain-to-md-html-paste branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment