New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move post-type meta box hooks out of location-based loop. #4257

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
2 participants
@schlessera
Member

schlessera commented Jan 3, 2018

Description

Move post-type meta box hooks out of the $location-based loop, so that they are not run three times without any obvious reason.

Resolves #4255

How Has This Been Tested?

All tests are still passing.

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
@youknowriad

LGTM 👍

For context, this was repeated per location because until recently, each location was rendered in a separate HTTP request.

@youknowriad youknowriad merged commit 0b93b06 into WordPress:master Jan 3, 2018

2 checks passed

codecov/project 39.15% remains the same compared to eb7b0b7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the schlessera:fix/metabox-addition-hooks branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment