List v2: remove quote transforms as removed by Quote v2 #42700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Block] List
|
Size Change: -107 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
remove/list-quote-transforms
branch
from
cad2edc
to
dd535f2
Compare
ellatrix
changed the title
This was referenced Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the Quote <=> List transforms as they no longer make sense.
See https://github.com/WordPress/gutenberg/pull/25892/files#r803141389.
These transforms were largely removed with Quote v2, but we took over List features form Quote v1 (before v2 was merged).
Why?
How?
Just a removal.
Testing Instructions
Lists can still be transformed to Quote (resulting in a quoted list) and the quoted list can still be unwrapped.
Screenshots or screencast