Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a PHPUnit Docker Container #4279
While it's easy to set up the local testing environment for JS, it's fiddly and annoying to set up a similar environment for PHP.
This PR adds a PHPUnit docker container, so that tests can more easily be run. It also includes
This is cool, thanks for working on it!
The existing docker container has fully working WordPress installation. I don’t know what the good practices about Docker are, but in theory we could setup everything inside one container. Question is if we want to keep them separate?
Another question is if we want to update Travis configuration to use newly added JS run scripts wrappers? The benefit of doing so would be the feedback from Travis if this setup works properly as project progresses.
I'm not particularly familiar with configuring Docker, so I found that using a pre-existing container was the easiest way to get it setup.
I think the PHPUnit behaviour could be merged into the WordPress container with a Dockerfile that installs all the necessary bits. I'll experiment a bit, and see how it works.
referenced this pull request
Jan 10, 2018
@WordPress/gutenberg-core: I would like your opinion on 2460ba1. The other npm scripts added in this PR are new, so I'm okay with them requiring Docker. Changing the
It seems to me like Docker is a pretty good option for a workflow that isn't awful to setup, but it does mean becoming more opinionated about the development environment. Working from a custom WordPress install will be trickier, for example.