New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Update for Table of Contents #4288

Merged
merged 3 commits into from Jan 4, 2018

Conversation

Projects
None yet
4 participants
@mtias
Contributor

mtias commented Jan 4, 2018

  • Change document counts to be a single row.
  • Reduce count sizes and invert order of count/number.
  • Increase width of panel — this is better for readability and preventing heading items from wrapping too soon. cc @afercia
  • Rename "word count" to just "words".
  • Makes line-divider full-width.

image

cc @jasmussen @karmatosed

Design Update for Table of Contents:
- Change document counts to be a single row.
- Reduce count sizes.
- Increase width of panel.
- Rename "word count" to just "words".
@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Jan 4, 2018

Contributor

Nice, goes nicely with #4287.

Contributor

jasmussen commented Jan 4, 2018

Nice, goes nicely with #4287.

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Jan 4, 2018

Contributor

Adjusted the balance of margins so that cases without headings are balanced:

image

Contributor

mtias commented Jan 4, 2018

Adjusted the balance of margins so that cases without headings are balanced:

image

@afercia

This comment has been minimized.

Show comment
Hide comment
@afercia

afercia Jan 4, 2018

Contributor

The bigger, the better.

I only have one a11y concern, related to a pre-existing issue. Re-ordering text and numbers should be avoided. It actually produces a mismatch between the visual order and the logical order. If the desired visuals is to have the text followed by the numbers, can we just do that also in the source? See also https://www.w3.org/TR/css-flexbox-1/#order-accessibility

Contributor

afercia commented Jan 4, 2018

The bigger, the better.

I only have one a11y concern, related to a pre-existing issue. Re-ordering text and numbers should be avoided. It actually produces a mismatch between the visual order and the logical order. If the desired visuals is to have the text followed by the numbers, can we just do that also in the source? See also https://www.w3.org/TR/css-flexbox-1/#order-accessibility

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Jan 4, 2018

Contributor

can we just do that also in the source?

Yes, definitely, good call.

Contributor

mtias commented Jan 4, 2018

can we just do that also in the source?

Yes, definitely, good call.

@mtias mtias merged commit 7623fbe into master Jan 4, 2018

3 checks passed

codecov/project 39.45% (+0.25%) compared to d01a464
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mtias mtias deleted the update/table-of-contents-design branch Jan 4, 2018

@karmatosed

This comment has been minimized.

Show comment
Hide comment
@karmatosed

karmatosed Jan 4, 2018

Member

Really like this :shipit: :)

Member

karmatosed commented Jan 4, 2018

Really like this :shipit: :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment