New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Use flatMap for mapping toolbar controls #4293

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Jan 4, 2018

Related: #3185

This pull request seeks to refactor the Toolbar component to achieve a minor performance and semantic meaning improvement, using Lodash's _.flatMap in place of a combination of Array#reduce + Array#concat.

See: https://jsperf.com/lodash-flatmap-vs-array-reduce/1

Testing instructions:

Verify that Toolbar unit tests pass:

npm run test-unit components/toolbar

Ensure that there are no regressions in the behavior of block or other toolbar controls.

@aduth aduth added the Performance label Jan 4, 2018

@jorgefilipecosta

Changes look good, no regression found 👍

@aduth aduth merged commit 55c5a79 into master Jan 4, 2018

3 checks passed

codecov/project 39.19% (+0%) compared to 7623fbe
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aduth aduth deleted the update/toolbar-flat-map branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment