Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToggleGroupControl: Improve styling for icon options #43060
ToggleGroupControl: Improve styling for icon options #43060
Changes from all commits
f213117
73b30db
46a6ada
7bc2bb4
fa743f7
901814e
1736150
37e6e45
0f21404
42d8192
02cc5d7
6b4f368
0d162a1
92260d8
684ec45
8cf4242
7141b7d
4efa533
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that TypeScript is allowing this — technically
isIcon
andsize
are not defined on neithertoggleGroupControlContext
norbuttonProps
.I'm not sure if we can pass props that are not part of
ToggleGroupControlOptionBase
's props via the "context system". If we want to pass "private", internal props, we may need to useuseToggleGroupControlContext
(and declare these props in theToggleGroupControlContextProps
type)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand it either, good catch.
I fixed this up.
size
is now private to the context system, andisIcon
is defined on OptionBase but not the final Option components. Final props tables of the Option components can now be verified in Storybook.