New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url input on images. #4324

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Jan 5, 2018

A wrapper div with the correct class was missing in UrlInput component.
This PR should fix issue #4253 and #4327.

How Has This Been Tested?

Add an image block, press the link input in the toolbar verify it appears as expected.

Fixed url input on images.
A wrapper div with the correct class was missing in UrlInput component.
@aduth

aduth approved these changes Jan 5, 2018

Should these styles be moved from format-toolbar/style.scss to url-input/style.scss?

@jorgefilipecosta jorgefilipecosta merged commit 490c857 into master Jan 5, 2018

3 checks passed

codecov/project 39.97% remains the same compared to d1df878
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/url-input-images branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment