New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Image: Fix style regression in textual placeholder #4326

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@mcsf
Contributor

mcsf commented Jan 5, 2018

Description

When transforming a Heading into a Cover Image block (#4129), the text from the Heading is carried over into a newly introduced placeholder view of the Cover Image block. This placeholder view prompts to pick an image while showing the text. A style regression recently slipped in wherein the text would render in Cover Image's default white:

Regression With fix
screen shot 2018-01-05 at 14 52 41 screen shot 2018-01-05 at 14 52 17

How Has This Been Tested?

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mcsf mcsf added the Blocks label Jan 5, 2018

@aduth

aduth approved these changes Jan 5, 2018

@mcsf mcsf merged commit c850779 into master Jan 5, 2018

3 checks passed

codecov/project 39.97% remains the same compared to d1df878
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mcsf mcsf deleted the fix/cover-image-placeholder-text-color branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment