New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image handlers from being unclickable #4334

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@mikeyarce
Contributor

mikeyarce commented Jan 5, 2018

Description

Fixes problem where the before pseudo-element from the previous block overlaps the top of the image handlers and makes them unclickable.

How Has This Been Tested?

  • I'm running WordPress locally using Valet 2.0.6 (nginx + mysql)

Screenshots (jpeg or gifs if applicable):

  • Before, when you tried to resize an image from either the top left or top right handlers, here's the overlap that I was seeing:

screen shot 2018-01-05 at 10 51 39 am

As you can see, the handlers were mostly underneath this before element and so they were very hard to click:
image-handler-click

With this change, the image handlers are now on top of the before element so they are clickable!
image-handlers-fixed

Types of changes

  • Bug Fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
Fix image handlers from being unclickable
Fixes problem where the ::before element from the previous block overlaps the top of the image handlers and makes them unclickable
@@ -29,6 +29,7 @@
.wp-block-image.is-focused & {
display: block;
z-index: z-index( '.wp-block-image__resize-handlers' );

This comment has been minimized.

@youknowriad

youknowriad Jan 10, 2018

Contributor

We used to follow the CSS selector to name the z-index but granted it's too complex here.

@youknowriad

youknowriad Jan 10, 2018

Contributor

We used to follow the CSS selector to name the z-index but granted it's too complex here.

@youknowriad

Thanks for the fix

@youknowriad youknowriad merged commit af8826b into WordPress:master Jan 10, 2018

2 checks passed

codecov/project 39.82% (-0.03%) compared to 255fe64
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment