-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FocalPointPicker: use KeyboardEvent.code, partially refactor tests to modern RTL and user-event #43441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
Refactor/focal point picker keycode code
FocalPointPicker: use KeyboardEvent.code, refactor tests to model RTL and user-event
Aug 19, 2022
ciampo
changed the title
FocalPointPicker: use KeyboardEvent.code, refactor tests to model RTL and user-event
FocalPointPicker: use KeyboardEvent.code, partially refactor tests to model RTL and user-event
Aug 19, 2022
ciampo
added
[Type] Enhancement
A suggestion for improvement.
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
labels
Aug 19, 2022
Size Change: -5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
changed the title
FocalPointPicker: use KeyboardEvent.code, partially refactor tests to model RTL and user-event
FocalPointPicker: use KeyboardEvent.code, partially refactor tests to modern RTL and user-event
Aug 20, 2022
ciampo
commented
Aug 20, 2022
tyxla
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work 🚀
Just needs a rebase.
} ); | ||
|
||
await user.click( dragArea ); | ||
await user.keyboard( '[ArrowDown]' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call to use ArrowDown
for the one test and ArrowUp
for the other 👍
ciampo
force-pushed
the
refactor/focal-point-picker-keycode-code
branch
from
August 22, 2022 09:07
003f57f
to
94f07a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the
FocalPointPicker
component to rely oncode
instead ofkeyCode
for keyboard eventsSince some tests were failing because they were relying on
fireEvent
, I went ahead and refactored them to usinguserEvent
(where possible) and with "modern" RTL style (i.e. avoiding implementation details).Why?
keyCode
is deprecated, and replaced bycode
How?
Easy swap of values
Testing Instructions
On Storybook, play around with the component and use the arrow keys while focusing the interactive part to move the focal point selection