New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocks-controls.md #4345

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@mhull
Contributor

mhull commented Jan 7, 2018

Description

alignment attribute was not declared within the block attributes and not used within the save function

How Has This Been Tested?

Since this is an .md file I could not test directly. I noticed the issue when following the documentation to learn Gutenberg and my code wasn't working correctly. I fixed my own example and then updated the documentation accordingly.

Types of changes

Documentation

Update blocks-controls.md
`alignment` attribute was not declared within the block attributes and not used within the `save` function
@youknowriad

Good catch, declaring attributes was optional at first :) but it's not the case anymore.

@youknowriad youknowriad merged commit 3991aa5 into WordPress:master Jan 8, 2018

2 checks passed

codecov/project 39.84% remains the same compared to 2f8ff09
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment