Post Terms: Refactor the usePostTerms hook #43503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Post Terms
|
Size Change: -48 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Thanks for the PR George! What do we gain from this refactor? The sync update is not a big deal I think, but still is something less than here 🤔 |
|
@ntsekouras, technically this is the right way for fetching terms assigned to a post. We'll also avoid issues like #41847. Unfortunately, I can’t use this method in the |
Mamaduka
force-pushed
the
update/use-post-terms
branch
from
284bbac
to
711a19d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR refactors the
usePostTermshook to usepostquery argument for fetching terms assigned to the post.A minor downside: Since terms are actually assigned after post save, if a block is used in the post editor and terms are assigned via the Document sidebar, they aren't immediately visible in the block.
I don't consider this to be a big issue in this case since the block is meant to be used by templates.
Testing Instructions
The block should work as before.