New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust horizontal edge detection for element nodes #4358

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Jan 8, 2018

Description

Fixes #4300. We currently don't check the offset correctly if a node is an element node. The maximum offset will then be the length of its children.

How Has This Been Tested?

Follow the steps in #4300. It should work now.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
@jorgefilipecosta

Nice fix 👍 It fixed the problem.
I discovered some possible improvements mainly when pressing keys continuously but no regressions.

@iseulde

This comment has been minimized.

Show comment
Hide comment
@iseulde
Member

iseulde commented Jan 10, 2018

@iseulde iseulde merged commit cf6f7ae into master Jan 10, 2018

3 checks passed

codecov/project 39.81% (-0.02%) compared to 37ae616
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the fix/edge-node-element branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment