New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial "templates" doc. #4367

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
2 participants
@mtias
Contributor

mtias commented Jan 9, 2018

Closes #4340.

@mtias mtias added the Documentation label Jan 9, 2018

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Jan 9, 2018

Contributor

Let's iterate on this.

Contributor

mtias commented Jan 9, 2018

Let's iterate on this.

@mtias mtias merged commit 16bae00 into master Jan 9, 2018

3 checks passed

codecov/project 39.82% remains the same compared to 0332862
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mtias mtias deleted the add/templates-doc branch Jan 9, 2018

@BinaryMoon

This comment has been minimized.

Show comment
Hide comment
@BinaryMoon

BinaryMoon Jan 9, 2018

Hi Matias. Looks good to me.

A few things I think would be good to include are:

  1. How to add a template to an existing post type (such as posts/ jetpack testimonials). I did this in my starter theme here but don't know if it's the best way: https://github.com/BinaryMoon/granule/blob/master/inc/gutenberg.php#L68-L99

  2. A note on how to find out what blocks are available. @youknowriad mentioned 'wp.blocks.getBlockTypes()' in #4340 which is very helpful. I think if you want people outside of the core developers to start using/ implementing Gutenberg features then things like this need to be as visible as possible. Possibly this could be added to the blocks api as well/ instead?

BinaryMoon commented Jan 9, 2018

Hi Matias. Looks good to me.

A few things I think would be good to include are:

  1. How to add a template to an existing post type (such as posts/ jetpack testimonials). I did this in my starter theme here but don't know if it's the best way: https://github.com/BinaryMoon/granule/blob/master/inc/gutenberg.php#L68-L99

  2. A note on how to find out what blocks are available. @youknowriad mentioned 'wp.blocks.getBlockTypes()' in #4340 which is very helpful. I think if you want people outside of the core developers to start using/ implementing Gutenberg features then things like this need to be as visible as possible. Possibly this could be added to the blocks api as well/ instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment