New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit edit mode when unfocusing a reusable block #4391

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
2 participants
@noisysocks
Member

noisysocks commented Jan 10, 2018

deselect

When a reusable block is unfocused, it should exit edit mode.

To test:

  1. Create a reusable block
  2. Click 'Edit'
  3. Unfocus the block
  4. Focus the block
  5. It should not be in edit mode, i.e. the 'Edit' button should be shown again
@@ -41,6 +41,15 @@ class ReusableBlockEdit extends Component {
}
}
/**
* @inheritdoc

This comment has been minimized.

@youknowriad

youknowriad Jan 11, 2018

Contributor

I guess this is required by the new JS Docs which is fine. Do we want to use @inheritdoc for all React lifecycle methods? Do you think we should add a message explaining the logic for this specific case "exit edit mode when unfocusing"? Or maybe the code is too obvious?

@youknowriad

youknowriad Jan 11, 2018

Contributor

I guess this is required by the new JS Docs which is fine. Do we want to use @inheritdoc for all React lifecycle methods? Do you think we should add a message explaining the logic for this specific case "exit edit mode when unfocusing"? Or maybe the code is too obvious?

This comment has been minimized.

@noisysocks

noisysocks Jan 11, 2018

Member

I think in this case that the code is pretty self explanatory. Personally, I'd prefer we do @inheritdoc for React lifecycle methods so that they don't distract a developer from the real doc comments that have real, useful information.

@noisysocks

noisysocks Jan 11, 2018

Member

I think in this case that the code is pretty self explanatory. Personally, I'd prefer we do @inheritdoc for React lifecycle methods so that they don't distract a developer from the real doc comments that have real, useful information.

@youknowriad

👍

@noisysocks noisysocks merged commit 19ea6de into master Jan 11, 2018

3 checks passed

codecov/project 39.77% (-0.02%) compared to 02e6e0f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@noisysocks noisysocks deleted the fix/deselecting-a-reusable-block branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment