ListView: Avoid paint on list view item hover #46188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @corentin-gautier! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
corentin-gautier
force-pushed
the
fix/list-view-paint
branch
from
6dc6f4d
to
618ab7d
Compare
ciampo
requested review from
ntsekouras,
youknowriad,
talldan,
andrewserong and
ciampo
ciampo
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Changes look good and test well as per instructions (e2e test failures don't seem related) 🚀
Thank you @corentin-gautier !
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
Co-authored-by: Corentin Gautier <corentin.gautier@consertotech.pro>
ryanwelcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoid paint when hovering the list view items
Why?
When hovering the list view items, paint is triggered all over the UI because of changes in zindex and position. This will result in poor performances
How?
Add a will-change: opacity and remove the changes in zindex/position
Testing Instructions
Screenshot
Before
Screen.Recording.2022-11-30.at.15.00.08.mov
After
Screen.Recording.2022-11-30.at.14.58.43.mov