Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort page parent dropdown by menu_order #4619

Conversation

Projects
None yet
3 participants
@billerickson
Copy link

commented Jan 21, 2018

See #4614 for a description of the issue being fixed.

@@ -72,6 +72,8 @@ const applyWithAPIDataItems = withAPIData( ( props, { type } ) => {
const queryString = stringify( {
context: 'edit',
per_page: 100,
orderby: 'menu_order',
order: 'asc',

This comment has been minimized.

Copy link
@danielbachhuber

danielbachhuber Jan 24, 2018

Member

Is it possible / does it make sense to add tests for this?

This comment has been minimized.

Copy link
@aduth

aduth Jan 28, 2018

Member

Is it possible / does it make sense to add tests for this?

What would you have in mind to test here? Simply that the generated query string matches expectations? There's enough variations that it could be helpful, though maybe non-blocking.

@aduth

aduth approved these changes Jan 28, 2018

@aduth

This comment has been minimized.

Copy link
Member

commented Feb 8, 2018

Well, I guess this has since been superseded by #4896.

Thanks for your work here all the same.

@aduth aduth closed this Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.