Replace registerStore() call with register() in the block-editor store #47447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Package] Data
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
@adamziel @ntsekouras I don't think it's possible to switch to I think this PR will introduce a bug that 'Most used blocks' is no longer persisted after reloading the editor. I have tried migrating block usage over to the new preferences API. I need to pick that back up again at some point. I think there's one remaining blocker, which is that the new preferences API calls the REST API for persistence, but doing that on every block insert would be a bit much. I need to come up with a better strategy. |
|
@talldan the code in registerStore is doing the same thing with what we're doing in register in conjunction with how we handle the creation of store in block-editor. 🤔 The issue your describe will need some investigation, yes. |
|
If you check out the commit to trunk before this (3dbd681), block usage works correctly, but since this commit it has been broken. While the code for registering looks very similar there must be some subtle difference. @youknowriad would know more. |
|
yep, this PR should be reverted until we switch the "preferences" persistence to use the new preferences package. The |
|
Thank you! I'll open a PR to make the changes! |
juanmaguitar
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
registerStore()is deprecated – this PR replaces its last usage in the Gutenberg codebase with the newregister()function call.Testing Instructions
Confirm the CI checks pass
cc @ntsekouras