New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editable: Rename the Editable component, RichText component for clarity #4779
Conversation
blocks/rich-text/editable.js
Outdated
constructor() { | ||
super( ...arguments ); | ||
// eslint-disable-next-line no-console | ||
console.warn( 'Editable is deprecated use wp.blocks.RichText instead.' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: this sentence could use a period. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already use a period?
Edit: Oh! maybe you meant something like that:
"Editable is deprecated, use wp.blocks.RichText instead."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did. :) Sorry, should have been more specific :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching some "editable" mentions in README.md
, but nothing that doesn't make sense as it's still an editable field. :)
I'd be in favor of this change. |
8b5df6c
to
0282eb6
Compare
0282eb6
to
4069064
Compare
This change is important enough to make sure is noticed, cc @mtias @karmatosed. |
I updated the "Editable" label to "Rich Text". |
Is Editable still available as a name for backwards compatibility? Or do folks need to switch to RichText right away? Thanks!!! |
It's available and will be removed in like two or three releases ;) |
👌 |
refs #4776
This PR renames the
Editable
componentRichText
to clarify that it's meant to be used for Rich Content exclusively and not as a replacement to inputs/textareas.We still export an
Editable
component for backwards compatibility with a warning asking people to useRichText
instead.Next step will be to implement a
PlainText
component and use it in one/two blocks. The blocks where we're currently usingTextareaAutosize
.Testing instructions