Navigator: add more pattern matching tests, refine existing tests #47910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
ciampo
commented
Feb 9, 2023
| @@ -98,25 +105,6 @@ function CustomNavigatorButton( { | |||
| ); | |||
| } | |||
|
|
|||
| function CustomNavigatorButtonWithFocusRestoration( { | |||
There was a problem hiding this comment.
Removed in favour of using CustomNavigatorButton everywhere, since today there are basically no differences between the two
ciampo
commented
Feb 9, 2023
| @@ -396,8 +428,6 @@ describe( 'Navigator', () => { | |||
| } ); | |||
|
|
|||
| it( 'should escape the value of the `path` prop', async () => { | |||
| const user = userEvent.setup(); | |||
There was a problem hiding this comment.
Moved part of this test to a new test (should restore focus correctly even when the path needs to be escaped). Reviewing commit-by-commit should make this part easier to review.
youknowriad
approved these changes
Feb 9, 2023
|
Flaky tests detected in dae7b0a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4137292770
|
ciampo
added
the
Backport to WP Beta/RC
ciampo
force-pushed
the
feat/navigator-more-tests
branch
2 times, most recently
from
447e3cd
to
2f3c758
Compare
ciampo
force-pushed
the
feat/navigator-more-tests
branch
from
2f3c758
to
dae7b0a
Compare
ntsekouras
added
Backport to WP Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 13, 2023
…7910) * Add one extra button to improve quality of focus restoration tests * Fix typo * Add screens with pattern matching to test component * Add named arguments tests * Refine invalid HTML attribute tests, split focus restoration part to new test * Remove reduntant component * CHANGELOG
|
Cherry-picked this PR to the wp/6.2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Following up the work in #47827, this PR adds more unit test to the suite of
Navigatorcomponents (and refines some existing ones).Why?
More tests, more confidence when making changes (especially in preparation for #47883)
How?
patternMatchunit tests)Testing Instructions
No runtime changes.
Make sure that unit test changes look good, and that tests pass.