Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alert callout in the block deprecation docs #50286

Merged
merged 1 commit into from May 3, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented May 3, 2023

What?

PR updates block documentation docs to use alert callout in block deprecation docs to highlight an important caveat.

Why?

The fact that attributes|supports block settings aren't inherited by deprecation objects can be easily missed and result in broken deprecation. See #50281.

Testing Instructions

CI is green.

The callouts are rendered only on the docs page, so testing locally is hard.

@Mamaduka Mamaduka self-assigned this May 3, 2023
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label May 3, 2023
@Mamaduka Mamaduka requested a review from ndiego May 3, 2023 12:05
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@github-actions
Copy link

github-actions bot commented May 3, 2023

Flaky tests detected in ba5386b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4871489279
📝 Reported issues:

@Mamaduka Mamaduka merged commit b2f752c into trunk May 3, 2023
50 checks passed
@Mamaduka Mamaduka deleted the update/block-deprecation-docs branch May 3, 2023 12:23
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants