New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Remove invalid reference to WeakMap polyfill #5079

merged 1 commit into from Feb 26, 2018


None yet
1 participant

aduth commented Feb 15, 2018

Related: #5002 (comment)

This pull request seeks to remove a reference to a WeakMap polyfill which is both invalid and unnecessary. Earlier iterations of what resulted in the rememo 2.4.0 release required WeakMap, so a polyfill was added to our script enqueueing. This was later turned into a soft dependency, leveraging WeakMap if present as an optimization.

Further, this polyfill does not work, because it expects a script handle matching the value in the tests array, but this was never registered.

Testing instructions:

Verify there are no regressions in editor usage, particularly around memoized selectors (block manipulation).

For extra credit, test in a browser which doesn't support WeakMap (IE11).

@aduth aduth added the Framework label Feb 15, 2018

@aduth aduth merged commit 09de363 into master Feb 26, 2018

2 checks passed

codecov/project 34.16% remains the same compared to cf1dd36
continuous-integration/travis-ci/pr The Travis CI build passed

@aduth aduth deleted the remove/weakmap-polyfill branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment