Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Framework: Remove invalid reference to WeakMap polyfill #5079
Related: #5002 (comment)
This pull request seeks to remove a reference to a WeakMap polyfill which is both invalid and unnecessary. Earlier iterations of what resulted in the rememo 2.4.0 release required WeakMap, so a polyfill was added to our script enqueueing. This was later turned into a soft dependency, leveraging WeakMap if present as an optimization.
Further, this polyfill does not work, because it expects a script handle matching the value in the tests array, but this was never registered.
Verify there are no regressions in editor usage, particularly around memoized selectors (block manipulation).
For extra credit, test in a browser which doesn't support WeakMap (IE11).