Blocks: Avoid autofocus behavior for blocks without focusable elements #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (don't autofocus the parent)
|
I don't know about others, but now I believe that some of the reproduced instances were false-positives: if the user moves the cursor ever so briefly (imperceptibly so) between clicking and releasing the click, the whole block is selected. Happens both in base and branch. |
|
Good find @mcsf this hints that the remaining issue is related to multi-selection :) |
|
:) That said, there are some occurrences that this PR does fix, so let's merge it! Steps:
|
mcsf
approved these changes
Feb 16, 2018
jorgefilipecosta
approved these changes
Feb 16, 2018
aduth
reviewed
Feb 16, 2018
| @@ -218,7 +218,8 @@ export class BlockListBlock extends Component { | |||
| } | |||
|
|
|||
| // Find all tabbables within node. | |||
| const tabbables = focus.tabbable.find( this.node ); | |||
| const tabbables = focus.tabbable.find( this.node ) | |||
| .filter( ( node ) => node !== this.node ); | |||
There was a problem hiding this comment.
I'm not sure when this could be the case? Following the logic, find will call querySelectorAll, which shouldn't include the source node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid auto-focusing blocks without any tabbable element.