New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery BLock: Backspace/delete removes the selected image in a gallery block #5143

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Feb 19, 2018

Just a small enhancement implementing the backspace/delete shortcut to remove the selected image from a gallery block.

This also fixes a small bug when removing the last item in a gallery.

Testing instructions

  • Select an image in a gallery block
  • Hit backspace
  • The image should be removed.

@youknowriad youknowriad added the Blocks label Feb 19, 2018

@youknowriad youknowriad self-assigned this Feb 19, 2018

@youknowriad youknowriad requested a review from jorgefilipecosta Feb 19, 2018

@jorgefilipecosta

Works well in my tests, and fixed a bug on the last one as referred 👍

@youknowriad youknowriad merged commit b4ba42b into master Feb 19, 2018

2 checks passed

codecov/project 34.4% (-0.03%) compared to da8184a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the backspace/selected-image-in-galleries branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment