Repository navigation
Add new block commands - #52509
Merged
Merged
Add new block commands#52509
Conversation
|
Size Change: +1.33 kB (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
draganescu
added
[Type] Enhancement
|
Flaky tests detected in 04f702a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5831950258
|
youknowriad
reviewed
Jul 11, 2023
youknowriad
reviewed
Jul 12, 2023
|
|
||
| export { default as BlockEditorProvider } from './provider'; | ||
| export { default as useSetting } from './use-setting'; | ||
| export { useBlockCommands } from './use-block-commands'; |
Contributor
There was a problem hiding this comment.
Do we need the Block in the name of this hook. It's already part of block editor so maybe it can be just useCommands which would stand for (use all block editor commands)
Contributor
Author
There was a problem hiding this comment.
I think it's fine to be granular? Is there any downside?
youknowriad
reviewed
Jul 12, 2023
| name: 'core/block-editor/blockActions', | ||
| hook: useActionsCommands, | ||
| } ); | ||
| }; |
Contributor
There was a problem hiding this comment.
Both of these command loaders use a lot of selectors... I do wonder about a potential performance impact on the command palette with long posts. Maybe it's fine though. One follow-up here could be to add a performance metric about the command palette.
draganescu
force-pushed
the
try/block-commands
branch
from
July 13, 2023 12:37
607d005 to
2e0709d
Compare
Contributor
Author
|
@youknowriad do you think this can land as is? Should I try and improve anything in particular? I see the tests (including perf.) don't complain. |
Contributor
|
Sure but let's get more testing first. |
Contributor
|
The only commands I see are the transforms. No Copy, Move, or any of the other examples from the video in the OP. Is that correct? I think it might be good to try displaying the contextual actions as suggestions immediately after opening the command palette, rather than having to search for them: 
Obviously we'll need to work out a mechanism to scale this as we add more actions, likely drilldowns: 
But that's a detail to figure out separately. |
draganescu
force-pushed
the
try/block-commands
branch
from
July 19, 2023 10:57
2739e81 to
66b6600
Compare
Contributor
Author
|
@jameskoster I think you should see transforms and some of the basic block actions like move, insert before etc. I tested to see if the PR is having some issue and apparently it's all right couldn't repro. Maybe its your build? In terms of UI - when do we know to suggest what? |
Contributor
|
Still only seeing the transform commands 🤔 Tried both post and site editors.
Worth a sanity check from @WordPress/gutenberg-design but I think it might be good to surface actions that apply to the selected block when the command palette is invoked. If you can detail exactly which commands this PR will add, we can work out priorities etc. |
Contributor
Author
|
@jameskoster this PR adds:
Showing all of them by default may be overwhelming. |
Contributor
Agreed. Since the aim of this PR is to add so many commands, let's not surface any suggestions yet. We can explore that in a follow-up with a thought-out design which considers how to scale the display of so many commands, if necessary. |
Member
|
Works well! Some quick bits, that could either be here or in a follow-up:
|
1 task
draganescu
force-pushed
the
try/block-commands
branch
from
August 8, 2023 03:12
66b6600 to
faf38ce
Compare
Contributor
Author
|
I've rebased and updated the PR with the comments from @richtabor . The icons part was a bit tricky as they are required by I made do with the icons we have. I don't think this to be a blocker as any visual tweaks can come in a follow up. I suggest we merge this to see if in the real world it causes any issues. Also I left the move to command on because it is extremely useful in distraction free mode, with the caveat that it looks bad :) |
scruffian
reviewed
Aug 11, 2023
| "@wordpress/wordcount": "file:../wordcount", | ||
| "change-case": "^4.1.2", | ||
| "classnames": "^2.3.1", | ||
| "clipboard": "2.0.11", |
Contributor
There was a problem hiding this comment.
This is a new dependency.
Contributor
There was a problem hiding this comment.
In other places, we just use event.clipboardData.setData
richtabor
self-requested a review
August 11, 2023 19:10
…ames, use add instead of insert
This reverts commit e6d70b2.
draganescu
force-pushed
the
try/block-commands
branch
from
August 14, 2023 12:11
e6d70b2 to
7a2ad93
Compare
Contributor
Author
|
I have reverted 6662c28 and removed copy and paste styles. The idea is to land the two hooks here with actions and transforms and see if there are any issues (perf) with them. For the copy and paste actions I'll follow up in another PR so we can have the time to spend on it without holding the rest back. |
Member
22 tasks
youknowriad
reviewed
Feb 12, 2024
| Array.isArray( clientIds ) ? clientIds[ 0 ] : clientIds | ||
| ); | ||
| return { | ||
| possibleBlockTransformations: getBlockTransformItems( |
Contributor
There was a problem hiding this comment.
In some contexts, this is triggering failures in the command loader. I'm guessing when the "blocks" array is empty.
cc @draganescu
Also @artpi for more details.
Contributor
There was a problem hiding this comment.
I'm still tracking down the exact reproduction path, but here is a stack trace I am getting when I run command loader quite often (for a different env that command pallette):
Contributor
Author
There was a problem hiding this comment.
I am not sure what to do to trigger a visible error. Ultimately empty blocks is guarded in getPossibleBlockTransformations by:
if ( ! blocks.length ) {
return [];
}
Contributor
There was a problem hiding this comment.
Yes, I see that in the code and yet I get the above stack trace. My suspicion is that we're getting [null, null ] or something similar
Contributor
There was a problem hiding this comment.
I finally have a reproduciton path. It took me quite a while:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Advances: #51559
Adds block selection related commands: block transforms and block duplicate, copy, remove, insert after/before etc.
Why?
Mainly to improve the usefulness of the command center, but also because this improve the distraction free mode experience by offering immediate access to basic functions without turn off the mode.
How?
Register the commands using mostly copied functionality from the block switcher and block actions components.
Testing Instructions
Screenshots or screencast
block-commands.mp4
To do