New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: Fix duplicate upload on drag #5257

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Feb 26, 2018

closes #5254

The image block has logic to upload a temporary image when it's mounted. This logic is necessary when pasting images. This means we don't need to upload the image in the drag and drop transformation and just rely on this behavior to avoid duplicate images.

Testing instructions

  • Drag and Drop an image to the post
  • The image should be uploaded only once

@youknowriad youknowriad self-assigned this Feb 26, 2018

@youknowriad youknowriad requested a review from jasmussen Feb 26, 2018

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Feb 26, 2018

Yep! Impressive! Can confirm this fixes it for me. Pasting also works.

By the way how cool a feature is that? Take a screencap using Shift, Control, ⌘, Option, then just paste it in the editor. Boom.

In any case, 👍 👍 ship it

@youknowriad youknowriad merged commit a63526a into master Feb 26, 2018

2 checks passed

codecov/project 39.56% (+0.01%) compared to 6e81725
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/duplicate-image-on-drag branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment