Columns: Adopt button and heading element colors - #54104
Conversation
There was a problem hiding this comment.
Thanks for putting this up, I had a feeling I might see a PR like this just around the corner 😀
✅ Columns-level elements styles are output correctly in editor and site frontend.
✅ Column-level elements styles correctly override Columns-level styles.
✅ Block-level elements styles correctly override Column and Columns-level styles, with the caveat about gradients as mentioned in the PR description.
There might be further container like blocks that we could opt into this color support for e.g. Cover, Media & Text, Details, Post Template etc.
Excellent! Cover block sounds like a good next candidate to me 🙂
LGTM! ✨
|
@andrewserong / @aaronrobertshaw nice. the day you will add shadow on column/columns (#44651) and column radius #41345 our price lists will say hourra ! ;-) |
Related:
What?
Adds the ability to specify colors for button and heading elements with Column/s blocks instances.
Why?
Provides greater flexibility in styling sections that may differ from the overall global styles e.g. a call-to-action pattern that might be darker or lighter than the overall theme.
How?
Opts into
buttonandheadingcolor support.Known Issues
There are some existing issues with the generic
headingelement gradient backgrounds overriding a simple background color on specifich1-h6elements. Similarly, a gradient applied by the container block can't be overridden by a simple background color set via an individual block within the container. These will be addressed separately.Next Steps
The might be further container like blocks that we could opt into this color support for e.g. Cover, Media & Text, Details, Post Template etc.
Testing Instructions
h1-h6) that matches one of the headings and confirm that overrides the generic heading element style selected earlierScreenshots or screencast