New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust after #5348 #5412

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Mar 5, 2018

Description

I don't really agree with all of the changes made in #5348.

  1. node will not always be a TinyMCE container, and therefore not always have an ID. Better to check right at the start if the container is empty?
  2. We don't really need the ID at all to use the TinyMCE utility function.

How Has This Been Tested?

Ensure fix in #5348 still works. In addition you can now use horizontal arrow keys on e.g. an empty paragraph.

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@iseulde iseulde added the Writing Flow label Mar 5, 2018

@iseulde iseulde requested review from mcsf and youknowriad Mar 5, 2018

@iseulde

This comment has been minimized.

Member

iseulde commented Apr 7, 2018

Any thoughts on this, @youknowriad?

@youknowriad

This seems to work as intended.

@iseulde

This comment has been minimized.

Member

iseulde commented Apr 12, 2018

Thanks!

@iseulde iseulde merged commit 4d8466e into master Apr 12, 2018

2 checks passed

codecov/project 39.57% (-0.01%) compared to 979904e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the fix/5348 branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment