Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Blocks: Add Upload button to audio and video blocks #5431
This PR adds the
I also added a few refactorings to make code more generic and work properly with the new requirements.
I also fixed a broken behavior of the
This should conclude pre-requirements to make it possible to merge #5211.
How Has This Been Tested?
Screenshots (jpeg or gifs if applicable):
Audio - file selected
Audio - editing
Video - file selected
Video - editing
referenced this pull request
Mar 6, 2018
Further improvements to consider
@karmatosed and @jasmussen - are there any plans to iterate further on the media-related blocks? Speaking myself, it seems like this PR bring images and other media formats closer in terms of UX. However, there are a couple of things we could tackle in the follow-up PRs I noticed when testing my changes:
It's not for a lack of desire to improve, unify, enhance things around media related blocks, it's purely a lack of resources, and so because they work, they haven't been prioritized.
Your list looks good, though, and I'd thumb up those improvements if they were made.