New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed blocks-... classes to components-... classes in input controls #5611

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
1 participant
@jorgefilipecosta
Member

jorgefilipecosta commented Mar 14, 2018

When moving the components from @wordpress/blocks to @wordpress/components we missed this change.
This PR just renames the classes, no other change is expected.

How Has This Been Tested?

No noticeable changes are expected from this PR. So some basic smoke testing + grepping should be enough.
Verify that in ./components we don't have any usages of classes with a "blocks" prefix.
The classes may have been used in styles outside /components folder. That was not the case to verify that we can search for this strings around all Gutenberg:

blocks-base-control
blocks-checkbox-control
blocks-radio-control
blocks-range-control
blocks-select-control
blocks-text-control
blocks-textarea-control
blocks-toggle-control

No occurrence should happen. All the classes replaced were from this list or had classes in this list as prefix and they were only used inside the ./components.

Renamed blocks-... classes to components-... classes in input control…
… components.

When moving the components from @wordpress/blocks to @wordpress/components we missed this change.

@jorgefilipecosta jorgefilipecosta self-assigned this Mar 14, 2018

@jorgefilipecosta jorgefilipecosta requested a review from WordPress/gutenberg-core Mar 14, 2018

@jorgefilipecosta jorgefilipecosta merged commit 7018b55 into master Mar 16, 2018

2 checks passed

codecov/project 40.44% remains the same compared to 1d6f3be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the update/rename-classes-from-blocks-to-components-input-controls branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment