New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-5604: Embed placeholder breaks upon reload #5624

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@wpjsio
Contributor

wpjsio commented Mar 15, 2018

Description

PR for issue #5604 If you insert an embed block that's empty, then reload the page, you get an error. The solution seems to be pretty simple: return null to return nothing in React.

How Has This Been Tested?

  1. Write new post
  2. Insert embed block
  3. Save draft or wait for autosave to kick in
  4. Reload the page

Screenshots (jpeg or gifs if applicable):

After fix:
embed_bug

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
Luke
Embed placeholder breaks upon reload
return null to return nothing
@notnownikki

This comment has been minimized.

Show comment
Hide comment
@notnownikki

notnownikki Mar 15, 2018

Member

Nice catch, and thanks for the fix!

Member

notnownikki commented Mar 15, 2018

Nice catch, and thanks for the fix!

@notnownikki notnownikki merged commit 46e59ab into WordPress:master Mar 15, 2018

2 checks passed

codecov/project 40.48% remains the same compared to e9c1c20
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment