New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Improve Disabled component (disabled attribute applicable, tabindex removal, pointer-events) #5748

Merged
merged 3 commits into from Apr 11, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Mar 22, 2018

Related: #5658 (comment)

This pull request seeks to improve the Disabled component to improve its durability in accurately disabling all interaction for content within. It resolves erroneous application of disabled attribute to non-eligible nodes as defined by the specification, removes any tabindex attribute as these elements are intended to be omitted from the tabbable flow, and prevents pointer interactions (the specification is not entirely clear here except for mention of preventing click events, and while the issue is under discussion at whatwg/html#2368 and w3c/pointerevents#177, the behavior is consistent with the majority of browsers).

Testing instructions:

The behavior on master is unlikely to change.

This was observed in the course of reviewing #5658, where mouse events on disabled controls being fired conflicts with hover behavior of accessing block options of a shared block preview of a nested block. Testing may require cherry-picking commits into try/improve-nested until the pull request is merged.

@aduth aduth merged commit 004cb8b into master Apr 11, 2018

2 checks passed

codecov/project 44.42% (+0.01%) compared to f00b08b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the improve/disabled-component branch Apr 11, 2018

@aduth aduth added this to the 2.7 milestone Apr 13, 2018

@phpbits

This comment has been minimized.

phpbits commented Apr 20, 2018

@aduth I can't find the changes where the blocks.BlockEdit were disabled on blocks inside the columns. I thought it's this one, would you mind pointing me to the right direction?

I've created this plugin : http://wordpress.org/plugins/block-options/ and the options I've added are not showing on the inner columns anymore. Thanks!

@aduth

This comment has been minimized.

Member

aduth commented Apr 24, 2018

Addressed at #6312 in response to duplicate comment at #6237 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment