From 3e3ba71ba8340b0098fe42d6b4aff859fce95189 Mon Sep 17 00:00:00 2001 From: Mario Santos Date: Wed, 24 Jan 2024 20:37:27 +0100 Subject: [PATCH 1/2] Use `lockUrlControls` variable in button --- packages/block-library/src/button/edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js index f6e465786ef69..7dffdfb5c1b66 100644 --- a/packages/block-library/src/button/edit.js +++ b/packages/block-library/src/button/edit.js @@ -336,7 +336,7 @@ function ButtonEdit( props ) { { isLinkTag && isSelected && ( isEditingURL || isURLSet ) && - ! metadata?.bindings?.url && ( + ! lockUrlControls && ( { From 222bd2738c50a0b5cd8cb73a3c04154739b8a6a4 Mon Sep 17 00:00:00 2001 From: Mario Santos Date: Wed, 24 Jan 2024 20:37:48 +0100 Subject: [PATCH 2/2] Add `linkTarget` to JS allowed blocks object --- packages/block-editor/src/hooks/use-bindings-attributes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/hooks/use-bindings-attributes.js b/packages/block-editor/src/hooks/use-bindings-attributes.js index 6f669f1a321c2..94aac654097e5 100644 --- a/packages/block-editor/src/hooks/use-bindings-attributes.js +++ b/packages/block-editor/src/hooks/use-bindings-attributes.js @@ -26,7 +26,7 @@ const BLOCK_BINDINGS_ALLOWED_BLOCKS = { 'core/paragraph': [ 'content' ], 'core/heading': [ 'content' ], 'core/image': [ 'url', 'title', 'alt' ], - 'core/button': [ 'url', 'text' ], + 'core/button': [ 'url', 'text', 'linkTarget' ], }; const createEditFunctionWithBindingsAttribute = () =>