Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Correctly translate FormTokenField placeholder #5937

Merged
merged 1 commit into from Apr 3, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 3, 2018

Related: #1141

This pull request seeks to use the correct __ translation function, not _ (presumably Underscore.js global) for the default value of the FormTokenField placeholder.

@aduth aduth added Internationalization (i18n) Issues or PRs related to internationalization efforts [Feature] UI Components Impacts or related to the UI component system labels Apr 3, 2018
@aduth aduth requested a review from youknowriad April 3, 2018 01:39
@aduth aduth merged commit 0b1f6d1 into master Apr 3, 2018
@aduth aduth deleted the fix/token-field-translate branch April 3, 2018 19:24
@aduth aduth added this to the 2.6 milestone Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants