Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed image add link input disappears issue #5942
When you begin typing anything in the image link input, it simply just closes the UI due to key events propagation, changing the states and triggering updates.
How Has This Been Tested?
Add image block and try to add a link from the toolbar. When you start typing, input should stay open.
Types of changes
Propagating to where to do what state changes?
Asking because while it occasionally has merit, I am very cautious of introducing
Okay, I pushed a fix to make sure the link suggestions show up when making image links.
The issue was that on mobile, the block toolbar has overflow auto so as to scroll horizontally. This hid the suggestions box in a weird scrollbar.
I fixed so suggestions don't show up on mobile at all. This is not an ideal fix, but suggestions weren't very mobile friendly in the first place. Suggest we get this in now as a bandaid, and then look at addressing suggestions on mobile separately, for example using the same technique the block switcher uses.
I also updated the way we fix the event propagation from closing the toolbar. This was happening because the