New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Use the WordPress package and remove the built-in implementation #6007

Merged
merged 2 commits into from Apr 10, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Apr 5, 2018

closes #5984

This PR updates Gutenberg to use the npm published i18n package.
It removes the built-in implementation of the package and all the related tools (babel-plugin, pot-to-php).

Testing instructions

  • Check that Gutenberg loads
  • Try another language, notice Gutenberg is translated properly.
  • Try running npm run package-plugin notice the pot and the php files are included properly in the generated zip.

@youknowriad youknowriad added the i18n label Apr 5, 2018

@youknowriad youknowriad self-assigned this Apr 5, 2018

@youknowriad youknowriad requested a review from gziolo Apr 5, 2018

@youknowriad youknowriad requested a review from WordPress/gutenberg-core Apr 9, 2018

@@ -79,7 +80,6 @@
"eslint-plugin-jsx-a11y": "6.0.2",
"eslint-plugin-react": "7.7.0",
"extract-text-webpack-plugin": "4.0.0-beta.0",
"gettext-parser": "1.3.0",

This comment has been minimized.

@aduth

aduth Apr 9, 2018

Member

We should also remove babel-traverse (used only in the plugin's tests).

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Apr 10, 2018

Any other concern here?

@youknowriad youknowriad merged commit 68d7265 into master Apr 10, 2018

2 checks passed

codecov/project 44.55% (-0.01%) compared to f598412
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/use-i18n-package branch Apr 10, 2018

@youknowriad youknowriad added this to the 2.7 milestone Apr 10, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Apr 10, 2018

Sorry for not being able to answer on time.

Any other concern here?

Yes, this is awesome. :) Once we are done with all updates to Babel config (I saw other PR touching it), I will spin PR in packages to find a way to move it there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment