New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo Content: Changed caption for theme compatibility clarity #6061

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
2 participants
@mikehaydon
Contributor

mikehaydon commented Apr 7, 2018

Description

Caption on the demo prompted user to click the "wide" button.

Wide button is an opt-in feature and we shouldn't assume the user will be able to click that button.

Reworded the caption so if the user doesn't see the "wide" button they know where to look to enable it.

How Has This Been Tested?

Tested on a local environment. It only affects that one line in the demo content.

Screenshots (jpeg or gifs if applicable):

2018-04-07_gutenberg_demo_text_issue

Types of changes

Bug fix of issue identified in #6058

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation. (N/A)
@gziolo

This comment has been minimized.

Member

gziolo commented Apr 7, 2018

Thanks for updating the caption 👍

@gziolo gziolo merged commit ef2e71b into WordPress:master Apr 7, 2018

2 checks passed

codecov/project 44.58% remains the same compared to 80185d7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mikehaydon mikehaydon deleted the mikehaydon:demo-caption-change branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment