New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TextControl with TextareaControl for image alt #6119

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
3 participants
@ajitbohra
Member

ajitbohra commented Apr 11, 2018

Description

Fixes #6095
Replace TextControl with TextAreaControl for the Textual alternative for the image block

How Has This Been Tested?

  • Manually adding image block & updating textual alternative
  • npm run test-unit

Screenshots (jpeg or gifs if applicable):

N/A

Types of changes

Non-Breaking

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@danielbachhuber danielbachhuber added this to the 2.7 milestone Apr 11, 2018

@danielbachhuber danielbachhuber self-requested a review Apr 11, 2018

@danielbachhuber danielbachhuber merged commit 1325bae into WordPress:master Apr 11, 2018

2 checks passed

codecov/project 44.54% remains the same compared to 446cdba
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@karmatosed

This comment has been minimized.

Member

karmatosed commented Apr 11, 2018

Just a little note but if it is a visual check lets try and get a design review on the PR also, just incase. Also having a screenshot would be super helpful in future to see how things are added.

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented Apr 11, 2018

@karmatosed Sure, sounds good.

@ajitbohra

This comment has been minimized.

Member

ajitbohra commented Apr 12, 2018

@karmatosed noted

@ajitbohra ajitbohra deleted the ajitbohra:fix/6095 branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment