Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed SelectControl keys; Removed unnecessary key from RadioControl; #6122
SelectControl used value as the key, but a user may pass two options with the same value in a select control. Now we use value and label as the pair to create the key.
Passing repeated values to a SelectControl may not make sense, but we should not throw errors even if that happens. In pure HTML an user can have a select with repeated values and no errors happen so using our control the same behavior is expected.
How Has This Been Tested?
Follow the steps described on #4873 and verify no duplicate key errors happen.