Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Better description for embed blocks #6124
How Has This Been Tested?
Screenshots (jpeg or gifs if applicable):
Types of changes
Nice, thank you for working on this!
The change seem to be good for all the embed aliases:
Though perhaps we could tune the description slightly so that it isn't as redundant. Maybe something like:
However this change doesn't look too good with the generic embed block:
Can we make an exception for the generic embed (the one you get if you just insert "Embed") block, so it keeps its original description?
@jasmussen Description updated
Not sure if below approach is right
should we check for 'Embed' or __( 'Embed' ) ?
Apr 18, 2018
Note that this is a tricky change when it comes to i18n. In English, there is no inflexion in "Service" in the sentence "Paste URLs from Service to embed the content", but other languages might have them. As a general rule, it's very hard to respect i18n when generating strings of this kind, with names interpolated.
A solution, although very cumbersome, would be to add strings for all these services in specific grammar cases, e.g.:
But I don't think the above would be practical at all, and would still likely break for some odd language that operates differently.