New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Disable login screen autofocus in Puppeteer tests #6129

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Apr 11, 2018

This pull request seeks to resolve an issue where the E2E test runner can have its login input clobbered by a script in the WordPress login screen which calls Element#select on the user login field after a 200 millisecond delay. While arguably this should be improved within core to check whether the field is already focused before trying to focus (or, more importantly, select), there is a filter exposed to disable the autofocus, which is taken advantage of here.

Testing instructions:

This is most noticeable with a short delay in the Puppeteer test runner. Verify there are no errors:

PUPPETEER_HEADLESS=false PUPPETEER_SLOWMO=20 npm run test-e2e

(You may need to re-setup your local Docker install to associate the new volume)

@aduth aduth requested a review from youknowriad Apr 13, 2018

@youknowriad

I can't reproduce the original issue but this works 👍

@aduth aduth merged commit 9966a96 into master Apr 16, 2018

2 checks passed

codecov/project 44.56% remains the same compared to 004cb8b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the improve/e2e-login-autofocus branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment