Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Meta Boxes: Only attempt apiRequest preload if path (fix meta box save breakage) #6130
Related: #6076 (comment)
This pull request seeks to resolve an error which prevents saving a post while a meta box is present. See #6076 (comment) for more context on the reason for the error.
Included is a new end-to-end test suite for meta boxes. Currently this only includes a verification that the post is saveable after dirtying, previously failing and now passing with the fix to the
Verify in your own browser that a post with meta boxes present can be saved.
Ensure end-to-end tests pass:
Oddly the tests were passing locally. I adjusted the tests to use a similar technique for awaiting click + navigate, defining the states of the button we expect to occur before triggering the save.
It feels a bit odd, because the call to
There seems to be some pattern emerging for defining the expected "waitFor" before any interaction which would cause those to be satisfied.
In any case, the tests pass now.